pydoc-markdown icon indicating copy to clipboard operation
pydoc-markdown copied to clipboard

Published 20 hours ago • verified publisher icon NiklasRosenstein

codeblocks rendering

Open ariG23498 opened this issue 5 years ago • 2 comments

In the conditional, the parser took for granted that the codeblock did not have any indentation. This made indented codeblocks to be overlooked. This caused problem with the generation of documentation.

I have added a simple .strip in the checking scheme itself so that the codeblocks are always triggered.

ariG23498 avatar Nov 26 '20 07:11 ariG23498

Hey @ariG23498 , thanks! Could you add a unit test? Also I think the PydocmdProcessor and SphinxProcessor could use the same change. 😅 If you have any ideas how to avoid replicating that bit of code across the three preprocessors, I'm open to suggestions.

Cheers

NiklasRosenstein avatar Nov 27 '20 20:11 NiklasRosenstein

Hey @NiklasRosenstein I made a unit test for the PR Feel free to review.

I think I need to look into the enhancement part for the other processors. But if I come up with something will definitely let you know. Cheers!

ariG23498 avatar Nov 28 '20 11:11 ariG23498