timeseries-generator icon indicating copy to clipboard operation
timeseries-generator copied to clipboard

Convert lint styling from flake8 to black

Open paulosgf opened this issue 1 year ago • 4 comments

Convert lint styling from flake8 to black

paulosgf avatar Jul 29 '22 17:07 paulosgf

I've done a post-merge review of #141 , there are a lot of unnecessary + to concatenate strings

@Abdur-rahmaanJ , Are we no longer using the properties specified in https://github.com/pyhoneybot/honeybot/blob/master/setup.cfg ? Especially line length

MrTanoshii avatar Aug 04 '22 08:08 MrTanoshii

@MrTanoshii I prefer to completely ignore isortlint and stuffs

The proper way is to have a pyproject.toml coupled with pre-commit as seen here

@paulosgf if you can implement as is in the other project? Thanks (isort and black)

Abdur-rahmaanJ avatar Aug 04 '22 09:08 Abdur-rahmaanJ

Sure! I was adapting the code base to the new lint style with black. Now I will be config the files. Later I'll make the pre-commit adjustment. In time: do you want that I keep the bandit security checks @Abdur-rahmaanJ ? ... and shall I keep the 100 char per line on lint?

paulosgf avatar Aug 04 '22 17:08 paulosgf

@Abdur-rahmaanJ Yes keep the Bandit check, for line, just let black's default handle that

Abdur-rahmaanJ avatar Aug 04 '22 19:08 Abdur-rahmaanJ