timeseries-generator icon indicating copy to clipboard operation
timeseries-generator copied to clipboard

Create top-level `assets` dir and move logo

Open MrTanoshii opened this issue 1 year ago • 9 comments

Goals

  • [ ] Create a top-level assets directory
  • [ ] Move logos to the assets directory
    • [ ] Fix any broken links

MrTanoshii avatar Jul 24 '22 20:07 MrTanoshii

Hello! Can I work on this?

akankshasainics avatar Oct 03 '22 12:10 akankshasainics

@akankshasainics , yes, you can! Please pay special attention no links point to README and our documentation on GitHub. Thanks!

paulosgf avatar Oct 03 '22 23:10 paulosgf

@paulosgf Thanks, but I can see this logo points to README.

akankshasainics avatar Oct 04 '22 09:10 akankshasainics

I guess that it's in documentation too, in https://pyhoneybot.github.io/honeybot/. There you can search how to proceed to update the documentation itself.

paulosgf avatar Oct 04 '22 15:10 paulosgf

Thanks! I'll check it out.

akankshasainics avatar Oct 05 '22 03:10 akankshasainics

Thanks! I'll check it out.

👍🏿

paulosgf avatar Oct 05 '22 13:10 paulosgf

@paulosgf I have one question. As per the documentation, I have copied gh-pages branch to the html folder. There is a _static folder that contains some logos. Should I move those logos to also assets directory?

akankshasainics avatar Oct 06 '22 12:10 akankshasainics

@paulosgf I have one question. As per the documentation, I have copied gh-pages branch to the html folder. There is a _static folder that contains some logos. Should I move those logos to also assets directory?

No. If you make, this'll create broken dependencies. But you should add these to your commit. Don't forget to test in your fork first.

paulosgf avatar Oct 06 '22 14:10 paulosgf

Thanks!!

akankshasainics avatar Oct 06 '22 16:10 akankshasainics