signal_analog icon indicating copy to clipboard operation
signal_analog copied to clipboard

Disabling a Detector appears to have changed.

Open greatestusername opened this issue 5 years ago • 0 comments

Issue: Disabling a detector no longer works.

Suspected Cause: API change on SFX side. We used to pass in disabled:disabled as an option for a detector to disable it. https://github.com/Nike-Inc/signal_analog/blob/master/signal_analog/detectors.py#L270-L280

Now it appears disabling a detector is with a PUT to /detector/{id}/disable https://developers.signalfx.com/detectors_reference.html#tag/Disable-Single-Detector

We will need to refactor to grab the id for the matching detector to be disabled and hit that endpoint.

greatestusername avatar Apr 25 '19 20:04 greatestusername