gimme-aws-creds icon indicating copy to clipboard operation
gimme-aws-creds copied to clipboard

UI and testing enhancements.

Open zelch opened this issue 1 year ago • 7 comments

Description

  • Add support for webauthn authenticator aliases.
  • Print a line when we detect that the user has touched the webauthn authenticator.
  • Allow disabling use of the system keyring with a configuration option.
  • Convert testing over to use pytest instead of nosetests.
  • Upgrade to 2.0.x of the okta python module.
  • As a significantly better fix for #362, handle multiple possible webauthn tokens by only having a single webauthn option in the factor list, and allowing any Okta configured token to be used.
  • Some misc cleanup for linter failures.

Related Issue

#362 #363 #364 #365 #322 #212

Motivation and Context

I would like to be able to recommend the switch to gimme-aws-creds in our internal environment, however without these changes I am currently unable to do so.

And I needed to switch to pytest so that I could test my changes successfully.

How Has This Been Tested?

This has been run locally, testing each change component, and then through the entire authentication process.

The test suite was converted to pytest, existing tests around registered authenticators were slightly modified to handle the argument and return value changes, and new tests were written for registered authenticators.

Screenshots (if appropriate):

Types of changes

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [X] My code follows the code style of this project.
  • [X] My change requires a change to the documentation.
  • [X] I have updated the documentation accordingly.
  • [X] I have read the CONTRIBUTING document.
  • [X] I have added tests to cover my changes.
  • [X] All new and existing tests passed.

zelch avatar Sep 14 '22 17:09 zelch