forestmodel icon indicating copy to clipboard operation
forestmodel copied to clipboard

Is it easy to support variable weight using point size?

Open ShixiangWang opened this issue 4 years ago • 4 comments

In the model, weight may contain important information. However, in current forestmodel, the point size is fixed. So I wonder it would be nice to implement this.

https://github.com/NikNakk/forestmodel/blob/dd8eb5579194ce13d78f6539f9e1c48b69c4b5d8/R/panel_forest_plot.R#L350-L354

ShixiangWang avatar Aug 12 '20 01:08 ShixiangWang

How would you propose scaling the points? I understand for a meta-analysis forest plot, but not one for a glm.

NikNakk avatar Aug 12 '20 06:08 NikNakk

@NikNakk Yeah, this is true. Some models may find it useful, but some others may not.

ShixiangWang avatar Aug 12 '20 07:08 ShixiangWang

Happy to review suggested code (or even just a suggested algorithm for calculating point size).

NikNakk avatar Aug 12 '20 08:08 NikNakk

Thanks, I will look into it in my spare time.

ShixiangWang avatar Aug 12 '20 10:08 ShixiangWang