XIVSlothCombo
XIVSlothCombo copied to clipboard
Nik-Potokar
[MNK] Internal Changes + UI Cleanup
- Demolish %HP slider
- UI cleanup
- added Simple mode - Advanced Mode for ST and AoE
- added old options to advanced mode
- removed old options from simple mode
- Meleechecks for ElixirField, Riddle Of Fire, Rising Phoenix and Meditation
- added low lvl aoe buffchecks and rotation
- added double solar opener
- add Dynamic TrueNorth to ST
- implement better Perfect Balance usage
- Implement better Beast Chakra usage
Will close #1056, #1348
has been tested for 3 ish weeks now and have had no issues reported back. seems good for me.
Let me know if anything else needs to change just in case!
Hi
I checked plugin built from you MNK branch
Why it does not weave forbidden chakra in opener?
In example, during Lunar Solar opener on a dummy you will have chakra limit before Elixir Field
But plugin not using it
It kinda not shown in The Balance opener graph, but you can refer to perfect balance video in example, where he uses Forbidden Chakra during opener to avoid overcap
https://youtu.be/cVkARdaslMQ?t=717
Hi I checked plugin built from you MNK branch Why it does not weave forbidden chakra in opener? In example, during Lunar Solar opener on a dummy you will have chakra limit before Elixir Field But plugin not using it It kinda not shown in The Balance opener graph, but you can refer to perfect balance video in example, where he uses Forbidden Chakra during opener to avoid overcap https://youtu.be/cVkARdaslMQ?t=717
That is correct. It is also not finished, hence the "in progress" tab :) rotation wise everything seems to behave, i just have to tweak the opener on behaving better
It would appear that meditation uptime is in a branch that conditionally checks for 5 chakras, but its own branch has as a condition to have less than 5 chakras, therefore, it seems to never be reached ? Taking it out of these branches and putting it in an else if branch after the meditation spender branch fixed it for me.
It would appear that meditation uptime is in a branch that conditionally checks for 5 chakras, but its own branch has as a condition to have less than 5 chakras, therefore, it seems to never be reached ? Taking it out of these branches and putting it in an else if branch after the meditation spender branch fixed it for me.
That is also correct. It will be dealt with today or tomorrow when I find time to continue developing the rework.
@tita9 @rad96
meditation should be fixed now using forbidden chakra in opener is temporary fixed, it is hardcoded in lunar - solar at the moment until i find a better fix for both openers.
@Kagekazu
why not just straight check chakra stack on entrance into opener function or something like that?
Because right now I see there is 3 usages of it during lunar solar
My logs, in example, in couple p12s pulls, shows that I can slap 5 forbidden chakras during opener
Here is example of some random log with guy doing 5 of them in double solar too
https://xivanalysis.com/fflogs/6zY32rHa94nfgXcQ/35/21
@Kagekazu why not just straight check chakra stack on entrance into opener function or something like that? Because right now I see there is 3 usages of it during lunar solar My logs, in example, in couple p12s pulls, shows that I can slap 5 forbidden chakras during opener Here is example of some random log with guy doing 5 of them in double solar too
https://xivanalysis.com/fflogs/6zY32rHa94nfgXcQ/35/21
I know it does, thats why it says "temp fix" since how it is programmed at the moment, i cant run the opener and have it check for 5 chakra's at the same time. so i'm looking at how i can change that.
Ideally i wanna make a function where it checks every step of the opener if it has 5 chakra's, if it does, weave in forbidden chakra, if it doesnt, continue to next step.
I built the changes into my own build and it looks gucci, I can't comment on rad's comments, I'm more of a casual, and am better at code than the game. :P
Will test more today, I'm leaving for two days afterwards, so far so good though. Thank you for your patience, your time and your work. :pray:
Edit: How about putting each of the checks that increment opener step at the top, put the check for forbidden in between, and all the actions at the bottom ? Does the last action variable changes the moment the action fires ? Just looking to help, I hope you don't mind.
I need a nap, I will test solutions when I wake up.
Edit2: I was laying in bed thinking about solutions, and I came up with this:
Result running it:
Of course, I made a list at the top that contains all the steps of the opener, and I changed OpenerStep to int, and made it = to 0 at line 31 and 80, so it reflects the index in the list. Am testing it repeatedly atm and I seem to be getting pretty consistent results IE: what we expect, forbidden moves around the line but everything seems to work as it should, I had it hitch once so far on like, a dozen runs, am trying to reproduce the case to fix it. Probably I would get more Forbiddens in a party with people feeding me chakra ? I hope this saves you some work. >//<
Edit3: I figured out the bad case, it's when I already have nadi, I would've known if I was a better mnk. :D Might want to look for that in conditions, though I doubt it matters outside of a scenario where I'm repeatedly doing the opener on a dummy.
Edit4: Tested in light party:
@Kagekazu here is a patch with fixes from @tita9 opener.patch Looks somewhat better I still clueless why now it can't reset fight sometimes (or it always was like that after your changes), but I think that's different issue
@Kagekazu here is a patch with fixes from @tita9 opener.patch Looks somewhat better I still clueless why now it can't reset fight sometimes (or it always was like that after your changes), but I think that's different issue
I think that's an ACT issue (or Overlay Plugin), I definitely leave combat when I reset striking dummy enmity, but yeah I noticed skilldisplay wouldn't reset between fights when testing, it's why I had to crop the light party part.
Happy to look further into the opener if there's other problems with it.
@Kagekazu here is a patch with fixes from @tita9 opener.patch Looks somewhat better I still clueless why now it can't reset fight sometimes (or it always was like that after your changes), but I think that's different issue
I think that's an ACT issue, I definitely leave combat when I reset striking dummy enmity, but yeah I noticed skilldisplay wouldn't reset between fights when testing, it's why I had to crop the light party part.
Happy to look further into the opener if there's other problems with it.
If you are talking about resetting opener, i will have it re added after i check the code, cause i dont think it resets properly at the moment.
@tita9 @rad96 changes have been pushed should start using forbidden chakra after Demolish. I also added an opener check if u already have a Lunar or Solar Nadi, so if u have 1 already it wont trigger the opener.
Resetting should be better, probably not perfect yet.
BTW @tita9 ur always welcome to PR to my MNK branch, might be easier
I have no idea how to handle github lol ;o; Will ask for help and learn, thanks for the invitation, very eager to contribute on stuff.
I tested the changes and it looks very gucci~ :D
BTW @tita9 ur always welcome to PR to my MNK branch, might be easier
I have no idea how to handle github lol ;o; Will ask for help and learn, thanks for the invitation, very eager to contribute on stuff.
I tested the changes and it looks very gucci~ :D
Can always ask info in the discord server, might be easier to communicate than on a PR :D