dpd-fileupload icon indicating copy to clipboard operation
dpd-fileupload copied to clipboard

Allow get requests without authentication

Open Mortgy opened this issue 9 years ago • 7 comments

Allow user to use GET requests with or without authentication with keeping authentication required for PUT / POST

Mortgy avatar Dec 08 '15 21:12 Mortgy

:+1: i've updated it

Mortgy avatar Dec 08 '15 21:12 Mortgy

im not sure if there is an easier way to get file mime type through ctx ? because the current method i used responding after file get uploaded then it reject it

Mortgy avatar Dec 09 '15 11:12 Mortgy

i guess filetype checking it could affect multi-uploading ? if user upload 1 allowed file type and 1 not allowed, response will be rejection for both when actually 1 file got stored and the other didn't, how about returning a response like this

[ { "filename": "4f3d2c6e2069d37af53dc08660f77f94.png", "originalFilename": "filename.png", "filesize": 396343, "creationDate": 1449660916139, "type": "image/png", "id": "757f512765994980" }, { "statusCode": 403, "message": "Uploaded file type isn't allowed." } ]

Mortgy avatar Dec 09 '15 11:12 Mortgy

Can you make multiple Pull requests? That would allow me to merge the easy features and to keep working on the other ones.

NicolasRitouet avatar Dec 09 '15 19:12 NicolasRitouet

if you merge now it won't merge all commits ?

Mortgy avatar Dec 09 '15 20:12 Mortgy

it will, but I want to merge this Allow user to use GET requests with or without authentication with keeping authentication required for PUT / POST and not the rest yet (since I'm not sure how to handle it)

NicolasRitouet avatar Dec 09 '15 20:12 NicolasRitouet

ok so create a pull request for that one for now

Mortgy avatar Dec 09 '15 20:12 Mortgy