Nicolas Hug
Nicolas Hug
Well TBH these statements are true for both strategies. I agree though that it's not so clear what strategy the author is refering to. E.g. p.36 eq. 2.4: > Let...
>you mean I may substitute current logic for .predict() for all kNN algorithms? No I think both options should be available, and the current one (even if it may not...
Quick update: I checked [mymedialite](https://github.com/zenogantner/MyMediaLite/blob/master/src/MyMediaLite/RatingPrediction/UserKNN.cs#L70) and [librec](https://github.com/guoguibing/librec/blob/2.0.0/core/src/main/java/net/librec/recommender/cf/UserKNNRecommender.java#L87) versions of kNN. If I understand their code correctly, they both compute the set of nearest neighbors and only then filter out those...
Like I said I prefer to keep the current version as the default one for backward compatibility reasons. If we change the default algorithm, then some people will find that...
I understand your point. Changing API and default behaviour in a next major release might be the solution. But for now, let's just keep the current startegy as the default...
>I consider leaving default behaviour as is - a bug proliferation. [...] all new users will have wrong default behaviour Once again, the current implementation is neither *wrong* nor *correct*....
> But they are commonly associated with the method [...] I didn't know that, thanks for the info. Would you have any reference? >I propose to implement such default behaviour,...
Sorry Олег I'm not sure I completely understand everything, but I don't see how this supports your claim that the different strategies are preferred depending on whether we're computing similarities...
Ok but it is simply specific to the proposed algorithm in this paper, not a general recommended practice, right? Anyway, let's keep things simple. The best course of action for...
`fix_k_closest` is misleading and does not reflect any of the two behaviours. `neighborhood` is versatile enough: we can allow different possible values later if we want to add more neighborhood...