Surprise icon indicating copy to clipboard operation
Surprise copied to clipboard

get_neighbors() should not be implemented for algorithms that cant use it

Open derek-saal opened this issue 7 years ago • 1 comments

Description

get_neighbors() is under AlgoBase() when it can't be used by all those that extend AlgoBase()

Expected Results

Consider removing this from base and implementing it where relevant.

derek-saal avatar Aug 06 '18 05:08 derek-saal

It can be used by any algorithm that uses a similarity matrix and I feel that it's not worth having another base class just for that.

But it's true that we could have a better error message in case the 'self.sim' attribute does not exist. Feel free to submit a PR!

NicolasHug avatar Aug 06 '18 10:08 NicolasHug