NicoNes

Results 33 comments of NicoNes

> I am not sure we can always detect this condition. It's sometimes difficult to prevent users from shooting themselves on the foot. Sure. I think we agree that `response...

Hey @ronsigal , I share your analysis and it makes me wonder too if caching support is useful. - Stage 1: As you said, since all implementations that passes TCK...

@ronsigal, About point 3 I think that I get you mean. Tell me if I'm wrong. It would be like what is already done with `Cookie` (representing request cookie) and...

Hey @ronsigal > As for bufferEntity() and getEntity(), if we keep the ability of getEntity() to retrieve a backing InputStream, then I think your suggestion makes sense. Otherwise, it's moot....

Hey @ronsigal , > I think your updated javadoc is good. I think there should also be an additional sentence or so to clarify that hasEntity() applies to either an...

Ok. So does it worth removing the "immediate" word in the doc or not to prevent confusion ?

Hey @spericas, To be sure to understand, do you mean this more like: **1. An "eager" approach** Like in an `Observer\Observable` pattern, the `SseBroadcaster` is a kind of `observer` for...

Hi @andymc12 and @spericas, Thanks for the response. I agree with both of you guys and I also prefer the "lazy" approach that is easier to implement > Is it...

@spericas , I agree with you. @andymc12 Don't bother about it, I will do it at the end of the week or the begining of the next one. Thanks guys

Hey @andymc12 @spericas Finally I got time to do the PR, here it is https://github.com/eclipse-ee4j/jaxrs-api/pull/887.