lixinyang

Results 29 comments of lixinyang

> Good catch. This patch solved the problem to some extent, I think the solution is that the newly created persistent subscription 'cursor position' is always greater than 'message-TTL' and...

@mattisonchao For clean expire ledger data, and the loaded topic need at least one ledger, this PR changes the behavior of rollCurrentLedgerIfFull, readd createLedgerAfterClosed() in rollCurrentLedgerIfFull I need your review....

> Hi @Nicklee007 Could you write a test to reproduce this case? @Technoboy- added unit test for the case 2, PTAL.

> @mattisonchao For clean expire ledger data, and the loaded topic need at least one ledger, this PR changes the behavior of rollCurrentLedgerIfFull, readd createLedgerAfterClosed() in rollCurrentLedgerIfFull I need your...

@codelipenghui @Jason918 @eolivelli Could you help to review this PR, Thx.

> Because we create the ledger lazily in the writing messages process, the trim also can not trim the current ledger. In this case, if we don't have any write...

> I think we still need to revert #14672 first (#16806). Because this PR just checks whether any cursor has been updated in the the periodically `BrokerService#checkConsumedLedgers` call based on...