David Nicholson

Results 308 comments of David Nicholson

Thank you @AlexanderJuestel for clarifying, that helps. For tests, the criterion to start review is just that you *have* a test suite and it runs in CI. You have met...

Sorry I missed your reply @AlexanderJuestel! Thank you @yeelauren for taking over :pray:

Welcome to pyOpenSci @monocongo and thank you for your submission! Good news: `climate_indices` passes most of the initial checks, and we think we have already found an editor for this...

Perfect, thank you @monocongo! Just let us know once you add those and the install instructions in the README. Looking forward to getting you a review!

Hi @monocongo just want to check back where you're at with API docs and adding install instructions to the README. If it's okay with you, I'll open an issue on...

Great, thanks for letting us know @monocongo. I will raise that issue later today so we can track. 🙌 we appreciate the work you're doing too! And on your PTO...

Not to butt in but just to add a couple comments from one of the reviews providing context about PyPA/build: https://github.com/pyOpenSci/python-package-guide/pull/55#issuecomment-1452584459 https://github.com/pyOpenSci/python-package-guide/pull/55#issuecomment-1453273897

Generally agree with this, adding a couple of other points: * importlib.resources can def get the job done for a handful of data files and has the advantage that it's...

Apparently there is now a table format although I can't find docs for it https://github.com/DrCoffey/DeepSqueak/issues/192#issuecomment-1499180882

Hi @sammlapp thank you for raising this issue and linking back to the thread in the forum. I know my reply there was a bit lengthy 😅 Long story short:...