protractor-flake icon indicating copy to clipboard operation
protractor-flake copied to clipboard

feat: only rerun tests from past run when we fail to find specs, and al…

Open Saqibm128 opened this issue 7 years ago • 3 comments

…low option to not rerun all

Saqibm128 avatar Apr 18 '18 00:04 Saqibm128

Could you provide some context on this pull request? I'm not sure I understand the use case. Thanks!

NickTomlin avatar Apr 18 '18 23:04 NickTomlin

allowing specs to restart completely in every scenario where the parser fails to find any tests but protractor still fails can be problematic. for example, some of the parsers fail if there is an error in either the before each or after each hook. in some cases, it may be better to just ignore the failure.

Saqibm128 avatar Apr 19 '18 00:04 Saqibm128

if the option to allow specs to restart when no specs are identified is allowed, at the very least we should keep track of the tests which have definitely passed and avoid restarting them. if they are restarted, they may flake again, even though they may have already passed before in a previous run. instead, let's just attempt tests from the previous attempt, i.e. redo tests from the last attempt we failed to parse, not all test specs

Saqibm128 avatar Apr 19 '18 00:04 Saqibm128