Bug: Throwing Ranges and Mighty Throw

[ThatGitMITZE]

Adding on here in case you forgot to note it down somewhere yourself Nick.

Currently, Mighty Throw is entirely redundant; not sure if Strength is at all a factor, but even with unmaxed Strength and without Mighty Throw you can throw throwing weapons (maybe even all objects?) the full LOS distance regardless of weapon weight, while in FA1 you definitely could not.

Basically, throwing distances need to be looked at again—I suspect Strength isn't a factor, not thrown object weight, and Mighty Throw is basically a trap specialty since it gives you nothing you can't get anyway without it.

[backwardsEric]

This is behavior inherited from Vanilla (for instance, cmd_get_target() does not have a range argument to indicate that the targeting is for something that has a shorter range than z_info->max_range). If it's decided to fix this upstream as well as for FAangband, than there's some overlap with this issue, https://github.com/angband/angband/issues/2849 , for Vanilla.

[ThatGitMITZE]

Addendum, I think I just remembered too there's a weird byproduct implementation in throwing ranges, where since range isn't limited, instead you start taking accuracy penalties or something past a certain target distance. At least, I think I'm remembering that correctly, and that Nick too conceded it was a weird way to go about things? I probably should have just posted these when we had the conversation a month or two ago, instead of now.

[backwardsEric]

The adjustment of to-hit for range is different in Vanilla and FAangband. Vanilla subtracts the distance from the to-hit chance for both launched and thrown missiles. Current FAangband compares the range to a maximum range and imposes a penalty to to-hit if the range exceeds the maximum range. That's done for both launched and thrown missiles. For thrown missiles, MIGHTY_THROW doubles the maximum range, and that's MIGHTY_THROW's only effect. Maximum range is not shown when targeting so the player does not feedback about that besides possibly noticing that the hit rate goes down for distant targets.