FAangband icon indicating copy to clipboard operation
FAangband copied to clipboard

Display Equippable comparison (~,p)

Open davidk64fnq opened this issue 1 year ago • 3 comments

Noticed a few issues with this but not sure whether it is used by anyone?

  • the second column has either "e" or "h" - not sure what this means
  • the first 26 columns I can see what they are then there is Bl = blows? then the last 8 are the fourth table from "C"/h information, how come third table is not shown I imagine it is intended to allow at a glance decisions about which home items a player wants to use but could be more user friendly if you had unlimited time!

davidk64fnq avatar May 17 '23 21:05 davidk64fnq

The documentation for the equippable comparison in Angband, https://angband.readthedocs.io/en/latest/command.html#game-status-commands , is mostly applicable to FAangband. The second column indicates the source for the object, it will either be 'e' (equipped), 'p' (pack), 'f' (floor where the character is standing) or 'h' (home).

To get the third table from the second page of the character sheet to show up in the equitable comparison, customize the game a little: copy ui_entry_base.txt from the game's lib/gamedata folder to the folder with FAangband's user preference files (Documents/FAangband on macOS, ~/.angband/FAangband on Linux, and lib/user in the game's directories on Window). Then edit the copy of ui_entry_base.txt with a text editor to insert category:EQUIPCMP_SCREEN at line 45 (i.e. between category:CHAR_SCREEN1 and category:modifiers for the group of definitions for numeric_modifier_ui_0. That will get the properties that are shown by their numeric values (those in the third table on the second page of the character sheet) to also appear in the equippable comparison.

As for why the "Bl" column (as you guessed, that is for extra blows) is showing up while the other entries from the third table on the second page of the character sheet do not, I suspect that is a bug in the code.

backwardsEric avatar May 18 '23 04:05 backwardsEric

I should've found that help entry! Thanks Eric. I followed the instructions which worked great. All makes sense now. Would close but I guess one day you'll want to fix the bug.

davidk64fnq avatar May 18 '23 05:05 davidk64fnq

I was wrong about the "Bl" entry, that's for the "blessed melee" flag. It doesn't show up on the second page of the character sheet because that page limits what's shown so it will fit in 24 rows, the minimum accepted size for the main window.

I'll test a pull request that'll address the equippable comparison issues (not displaying the numeric modifiers and the two character abbreviation for "blessed melee" being the same as the abbreviation for "attack speed"/"blows"). Then what will remain to be done is to see if the "blessed melee" flag should be shown on the second page of the character sheet.

Thank you for for the bug report.

backwardsEric avatar May 18 '23 14:05 backwardsEric