Nick Heiner

I'm having a bit of a hard time figuring out how much ARIA work was actually done. None of the checkboxes in the original issue are checked. Some of the...

Here's a PR! You can decide if it's quality 😸. https://github.com/angular-ui/bootstrap/pull/6166

@jcwarfield can you try my PR (#6203) and tell me if that fixes your problem?

Ah yes, then my PR is not going to help you. That's a separate issue. And yes, I have seen it make a difference whether a DOM attribute exists when...

:+1: It would be awesome if `grunt.initConfig` accepted a promise for a config object.

@dnutels It could look something like this: ``` js module.exports = function(grunt) { var configPromise = getConfigBasedOnFileSystemContents(); // either this configPromise.then(grunt.initConfig); // or this grunt.initConfig(configPromise); // in this case, no...

I would be a little cautious about the finer granulation - if you see something like ``` js grunt.initConfig({ copy: somePromise, clean: someSettings }); ``` How do you know that...

:+1: This would also be helpful when you have a bunch of subtasks for `clean` and running them all at once is an uncommon scenario.

I think the minimal repro is literally just "update this repo to TS 4.8 and see if it builds". I tried to do that myself, but I got this error...

I tried and it doesn't build. Here's the branch demonstrating it: https://github.com/relay-tools/relay-hooks/compare/master...NickHeiner:relay-hooks:nth/ts-4.8?expand=1. ``` src/useRelayEnvironment.ts:8:13 - error TS2339: Property 'environment' does not exist on type '{}'. 8 const { environment }...