Nick Crews

Results 281 comments of Nick Crews

The nix CI failure looks like a flake, but IDK what is going on with postgres, any idea? just mark as notimpl?

I would still love to enforce the `test_impure_correlated` test and the `test_chained_selections` test`, so we can enforce that `table.select(common=ibis.random()).select(x="common", y="common")` works as expected, on as many backends as possible. This...

This is related to https://github.com/ibis-project/ibis/pull/9065, where we decided to merge selects by default, but provide an option for not merging them. I think we need to never merge them, and...

Nice job finding those bugs and fixing them! Looks great. I was surprised when I had to make duckdb as xfail, I thought these semantics they would get right. Reminder...

A few ideas that I have had to do: - `t1.count() == t2.count()` (where unlike in the original example t1 and t2 are totally unrelated eg from different parquet files)...

OK, that's fair. Could we do something else to make debugging easier though? - include the SQL in the custom error, eg ```python raise IbisError( "Failed to parse SQL. This...

OK, I think this brings up a larger philosophical question: Do we want to totally separate the pandas and pyarrow codepaths, or can they rely on each other? Currently, to...

Ok, when I get back to this I'll try the db -> arrow method!

viable, I just stopped needing it personally so the urgency of it dropped a lot compared the 5 million other PRs I have open haha. Feel free to close if...

hmmm, I think you are right. We are victims of the SQL standard here. I don't really like this footgun: - `ibis.literal("abcde").substr(2, None)` gives "cde", but - `ibis.literal("abcde").substr(2, ibis.null())` gives...