Nick Crews
Nick Crews
driveby-ing: `def enumerate(arr: ArrayValue)` feels very close to `def zip(arr: ArrayValue, *others: ArrayValue)`, and I have wanted zip before but did workarounds.
I agree I want to avoid the print() I personally have no use for getting a rich table, but I could see someone else wanting a .to_rich() method? Could add...
yeah, easy enough to expose/figure it out later if you get a feature request, but hard to take back :)
OK, not sure why the widths of the tables are changing in the doctests, I don't see what is different. But I can dig into that once the other questions...
for myself: can repro the doctest failure with `pytest --doctest-modules ibis/expr/types/maps.py` @cpcloud so now the only test failing are the doctests. I'm not sure exactly what is causing the change...
OK the failing doctests are only for nested datatypes. There is some conditional logic inside `to_rich_table()`, which I think is the culprit ```python if show_types and not isinstance(dtype, (dt.Struct, dt.Map,...
no, that's not it. On `main`, `to_rich_table` is getting called with `width=153` (or the width of the rich console) found in __interactive_rich_console__. on this branch, `to_rich_table` is getting called with...
OK, there was an inconsistency between the `__interactive_rich_console__` implementations in Column vs Table. Now they are unified, along with Scalars
@cpcloud OK now I got this all fixed up! Can you review this now? The implementation has changed decently since the last time you looked. This is doing both a...
@cpcloud sorry to bug you, could this get a review? I can fix the rebase error once I get a +1 on the general approach