Nick Condron

Users can accidentally design broken CLIs when combining subcommands with unbounded positional arguments

1

Maintainer's notes: Below is the original issue that came from misusing clap's API. We could add a debug assert to help guide users to use the API correctly. --- ###...

Creates a component that works with harpoon (https://github.com/ThePrimeagen/harpoon) showing the current file's harpoon index (if it exists). Right now this is a proof of concept. I want to hear your...

Fix Sonokai theme to better match original

2

The Sonokai theme had some inconsistencies, so I fixed some of them. * Copied the palette exactly from https://github.com/sainnhe/sonokai/blob/master/autoload/sonokai.vim * Used the following two resources to pick correct colors for...

Building Steps don't produce files in correct directories

1

The Start.dol file should be placed in a &&SystemData folder within the 'Additional ISO Files' folder. Also, it would be worth it to include opening.bnr and ISO.hdr files

Handle in-progress replay length correctly

1

Fixes #26 by preventing a negative length from being passed to `_parse_events` A separate question is to decide what it means if the user passes `skip_frames = True` for in-progress...

Impl read_exact for TrackingReader

1

This allows the reader to utilize the specialized `read_exact` of the inner type instead of the default implementation. This provides a speedup of 10-20%.

Implement `Default` trait for `Version`

2

Slippi replay base version is 0.1.0 A user might want to use `Version` to encode some sort of compatibility information in a type (eg. certain stats only work for certain...

Unfortunately these fields often have garbage values in them that we need to store in order to do round-tripping. Let me know if there's a better way to structure this...

Parse Gecko Code contents

1

Looks like slippi-js is implementing this feature (https://github.com/project-slippi/slippi-js/compare/feature/gecko-list), so we probably should too. Documentation on gecko codes is oddly hard to find, but I found this: https://gamehacking.org/faqs/wiicodetypes.html https://web.archive.org/web/20191211012905/http://geckocodes.org/index.php?arsenal=1 https://github.com/FIX94/Nintendont/blob/master/codehandler/codehandleronly.s https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/GeckoCode.h...

There's a long-standing bug in Slippi where Game End events are not always written to the Slippi file (see first paragraph in spec for Game End event https://github.com/project-slippi/slippi-wiki/blob/master/SPEC.md#game-end). There are...