NickAcPT
Hosted instance could hit Mojang rate-limits and some skins fail to renderer as a result
Hello
Some skins return a normal steve instead of theire actual skin. I tried rendering the skin of the player juliu_Z (https://de.namemc.com/profile/juliu_Z.2)
the UUID is ac047308-c017-49e1-b3a4-01d7bd9b2bd1 https://nmsr.nickac.dev/fullbody/ac047308-c017-49e1-b3a4-01d7bd9b2bd1 returns a Default skin despite him having a skin This issue occurs on multiple Accounts i have tried, but not all
I have not yet found a pattern which skins do not work
Other examples are 66b374c5-d379-47f7-b845-a0f5f8375a0a f791e6b9-d8e5-4f53-a869-de491cdf4df5
@DanielSchmerber hey there, apologies for not getting to you sooner.
I had a look at the tracing logs from these specific requests and I noticed that my hosted instance was hit with a rate limit (http error 429), served by Mojang on requests for game-profile lookups from Uuids.
Has this issue been causing much impact? If so, I'd have to look at ways of balancing these outgoing requests on the hosted instance somehow.
Hello, thanks for taking the time to look into the Problem!
As ratelimits are the Issue, i will make efforts to reduce the amount of request being sent to the service. This has a minimal Impact, and has not happend again since reporting this Issue
As ratelimits are the Issue, i will make efforts to reduce the amount of request being sent to the service.
@DanielSchmerber Feel free to keep sending your usual amount of requests to the web server, you don't have to worry about it ^^ The hosted service hitting the rate-limit isn't due to these requests. Right now I'm not load-balancing requests to Mojang, but will keep an eye on it.
In the meantime, if you hit any issues on this again, feel free message here, or through Discord (@nickac).
Hey @DanielSchmerber, just to keep you updated on this, commit https://github.com/NickAcPT/nmsr-rs/commit/e621000a156b3a29502cbfc77d966a227e40c02b introduced a way of load-balancing outgoing requests to Mojang.
Right now, the public instance is using this feature to try and avoid rate-limits. And like I said in my previous comment, feel free to send your normal requests to the service.