nice-node
nice-node copied to clipboard
NiceNode
feat: client sync percentage & dynamic RPC handling
It's been awhile since I've worked on this so it's a little difficult to provide specifics 🥲
- Enabled client cards on Node screen
- Add different port to new node if it already exists in configs
- Removed hardcoded RPC addresses, and implemented dynamic RPC handling
Note:
- Some client sync percentages may not work properly due to differences in clients and how they process sync status. Will require a handler for each case.
- Not with my Linux box to confirm, but I remember seeing a bug where the same client stats is shown when changing node package view in the initial sync stage. I remember it fixing itself when the node is done syncing beyond a certain point.
Deploy Preview for nndesign ready!
| Name | Link |
|---|---|
| Latest commit | 6b6601d16727b8195462f548c7a7827cd93369ec |
| Latest deploy log | https://app.netlify.com/sites/nndesign/deploys/664fa85e625c9300087e9bf4 |
| Deploy Preview | https://deploy-preview-523--nndesign.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Several notes:
-
I found a bug running Besu. If I run an Ethereum package already, and create a new one with Besu, the same port is being set to HTTP API and WS which results in a crash - normally, this would be okay as long as rpc-ws-enabled is false, but it's set to true, so it doesn't work, as expected. The actual bug is that the same port is being set - something must be wrong when assigning new ports to the node. I'll have to take a closer look.
-
Found another issue, where if I stop the nodes, change the WS Enabled setting to true, restart the node from Node Package view, and look at Besu logs, it shows: Error: no container with name or ID "XXXXXXX" found: no such container @jgresham
-
Saw multiple re-renders in the node package with the rpcExecution calls, and sometimes see that httpPort is missing in order for rpcExecution to work; will need to look into this...
Really looking forward to these two major feat/fixes!
Add different port to new node if it already exists in configs Removed hardcoded RPC addresses, and implemented dynamic RPC handling
