nice-node icon indicating copy to clipboard operation
nice-node copied to clipboard

Windows multiple nodes does not work. Nodes overwrite or fail without an error message

Open ConnorBP opened this issue 2 years ago • 6 comments

Problem details

When you try to add more than one ethereum node to nice-node, it breaks in multiple ways;

node1: Nethermind + Lodestar

One issue type: When you add a second node, on a different network, but with the same validator and consensus clients it disables the clients on the first node and then overwrites them with the second nodes clients. The first node then ceases to function.

What should happen: It should make a separate instance of each client for this network and run them on a new port and container.

Another issue: When you try to add a second ethereum node for a different network with a different consensus and validator such as reth and nimbus, the clients fail to start entirely and do not mention any reason or log anything.

What should happen: The node should either create successfully along side the existing nodes, or prompt you with a reason why exactly it failed.

RAM: 64 GB ddr5 Storage 1700 GB free high speed NVME cpu: 16 thread ryzen 7700x

ConnorBP avatar Nov 19 '23 21:11 ConnorBP

The ports are conflicting and the second node will crash if it cannot connect to the default port. If you would like a temporary work around, you can open the client settings and change the ports manually.

We don't yet handle ports well with multiple nodes. We are aware of this issue and will hopefully get to it in the next month or so! We want to implement a solution which will work well across all node types. Thank you for reporting this. cc @corn-potage

jgresham avatar Nov 20 '23 23:11 jgresham

The ports are conflicting and the second node will crash if it cannot connect to the default port. If you would like a temporary work around, you can open the client settings and change the ports manually.

We don't yet handle ports well with multiple nodes. We are aware of this issue and will hopefully get to it in the next month or so! We want to implement a solution which will work well across all node types. Thank you for reporting this. cc @corn-potage

Thanks for the workaround. This should solve the error when node type is different. Will there also be a fix for selecting the same node type causing it to overwrite the first nodes containers?

ConnorBP avatar Nov 22 '23 21:11 ConnorBP

By overwriting other nodes, do you mean overwriting their data? All nodes have separate data directories and therefore should not overwrite each other.

There is a known bug, with NiceNode & reth's config, that reth does not save data when using it on a testnet.

jgresham avatar Nov 22 '23 22:11 jgresham

By overwriting other nodes, do you mean overwriting their data? All nodes have separate data directories and therefore should not overwrite each other.

There is a known bug, with NiceNode & reth's config, that reth does not save data when using it on a testnet.

As in when you start a new Nethermind instance, the existing one gets shut down and the new one takes its place but under the new node. Therefor breaking the first node.

ConnorBP avatar Nov 23 '23 18:11 ConnorBP

Ok I understand. There is a simple naming conflict on the containers. We can fix this easily. To be clear, this would allow a user could run two nethermind nodes

jgresham avatar Nov 23 '23 18:11 jgresham

Ok I understand. There is a simple naming conflict on the containers. We can fix this easily. To be clear, this would allow a user could run two nethermind nodes

Exactly

ConnorBP avatar Nov 24 '23 05:11 ConnorBP

Closing as #546 better describes the root problem now

jgresham avatar Apr 22 '24 21:04 jgresham