nheko icon indicating copy to clipboard operation
nheko copied to clipboard

Support markdown input for strikethroughs

Open VarLad opened this issue 4 years ago • 4 comments
trafficstars

The Problem

nHeko Reborn supports md, but not strike throughs

The Solution

When typed

Hi, I am ~~not~~ an alien

It should render as Hi, I am ~~not~~ an alien

Alternatives

No response

Additional context

Screenshot from 2021-10-11 17-11-52

Current state of the problem

Happens in the latest version

  • [X] Yes, this feature is still missing.

VarLad avatar Oct 11 '21 11:10 VarLad

You can enter <del>not</del> for now at least.

deepbluev7 avatar Oct 11 '21 12:10 deepbluev7

Thanks for the workaround Although, lets keep the issue open until it gets implemented so others can find the issue and the workaround as well

VarLad avatar Oct 11 '21 14:10 VarLad

Really, this problem will only be fixed if we switch to a different MD parser; CommonMark isn't going to just add extra features to their reference implementation, which is what we use.

LorenDB avatar Apr 26 '22 01:04 LorenDB

I mean, there is a cmark variant that supports the github extensions, which includes strikethrough (cmark-gfm) or we could just write an extension for cmark ourselves, that we use in addition to the current parser.

deepbluev7 avatar Apr 26 '22 02:04 deepbluev7

Fixed in ec3ba352c0a46b3776b224cb3101619698fa8e26, some limitations apply.

deepbluev7 avatar Jan 28 '23 09:01 deepbluev7

@deepbluev7 for some reason it's not getting rendered in my 0.11.3:

hiiamboris avatar Apr 23 '23 19:04 hiiamboris