nheko
nheko copied to clipboard
Nheko-Reborn
Support video calls on Windows
Screen capture support should be possible using gdiscreencap: https://gstreamer.freedesktop.org/documentation/winscreencap/gdiscreencapsrc.html?gi-language=c
Only need to write some additional code to select a window and such.
Not sure why my issue was marked as a duplicate of this one and closed, since this is about video calls and mine was about voice calls, but the main page should specify that this feature doesn't work on Windows. My friend and I wasted a good bit of time on this specifically because it clearly states that VoIP is supported.
Well, in any case calls on windows need the gstreamer dependencies to be packaged, which is not the case yet. While screen sharing will need some extra work on Windows, this issue in general is about calls as a whole or at least that was the intention originally :3
At least with the changed title it fits. Wasn't against the idea of merging, just didn't make sense to call it a "duplicate." As I said in the other issue, we installed gstreamer but it still didn't work, so I'm guessing there's more to it than that. Just that the other issues I linked there seemed to suggest that's what was needed.
I just hope you'll update the main page, because as much as I like the idea of Nheko, voice and, to a lesser extent, screen sharing are requirements, so Nheko won't work for me, and had I known that, I wouldn't have spent the time on it. I'll definitely be keeping an eye out for this functionality to be added, though, and I can help with testing if needed.
Just installing gstreamer won't fix it. It needs to be there during build time (and then installed together with Nheko, if it gets packaged). We did test that that works before and it worked okayish, it could however have regressed. But we have no Windows devs, so this issue isn't seeing very much action. But yeah, we should update the README.
If this is just an issue of making sure gstreamer is available at build time, the minimum gstreamer features needed could be provided via vcpkg instead of requiring developers and packagers to go through the trouble of building it separately for the target toolchain.
