nginx-proxy-manager icon indicating copy to clipboard operation
nginx-proxy-manager copied to clipboard

Access List + Restart = invalid Cert on all endpoints with access list applied

Open JohnGalt1717 opened this issue 4 years ago • 15 comments

Checklist

  • Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image? yes
  • Are you sure you're not using someone else's docker image? yes
  • If having problems with Lets Encrypt, have you made absolutely sure your site is accessible from outside of your network? na

Describe the bug Per Title

To Reproduce Create an access list that has an internal subnet white listed (i.e. 10.0.0.0/8). Apply it to endpoints and save with let's encrypt certificate. Save. Verify that it works without issue Restart nginx proxy manager docker container Close browser, open it again and go to same url

-- Results in invalid certificate and inspection shows that it's the dummy certificate.

Go into the endpoint Save the endpoint without changes Refresh browser Works fine again.

Note that all endpoints that do not have an access list assigned work fine.

Expected behavior Should survive restarts properly and apply the certs correctly without having to save the endpoints individually every time.

Operating System Ubuntu 20.10

JohnGalt1717 avatar Feb 12 '21 17:02 JohnGalt1717

I can confirm this. As so far that the issue I am seeing is very similar.

(I am on the latest docker version 2.7.3)

Change an access list, by adding/removing an IP range on the access tab. Then all the proxies using that end point have invalid certificates. It appears this is because the region # Let's Encrypt in the data/nginx/proxy_host/00.conf is missing. Opening and saving the proxy restores the missing data.

Kareltje1980 avatar Feb 21 '21 21:02 Kareltje1980

Also confirmed that this bug still exists. I am using NPM version 2.8.1 from the jc21 docker image.

@Kareltje1980 solution was a fix for it, but I had to open 20+ proxies to fix it. But its not ideal.

apainter2 avatar Apr 26 '21 15:04 apainter2

I can confirm that this bug still exists in NPM version 2.9.6 hosted via docker. @Kareltje1980 solution still works but is not ideal obviously.

tgrimminger avatar Aug 06 '21 15:08 tgrimminger

Confirmed, I've got this issue too with ubuntu 20.04.2 LTS server as the docker host.

Upgraded to 2.9.7 and still experiencing the issue.

SteveGBuck avatar Aug 13 '21 14:08 SteveGBuck

Upgraded to 2.9.9, issue still exists.

AlfaJackal avatar Oct 11 '21 11:10 AlfaJackal

Still experiencing this issue in version 2.9.12. After editing an access list, all of the proxy hosts with that access list selected start using a self-signed certificate instead of the Let's Encrypt one. The workaround described by @Kareltje1980 appears to be working.

kffl avatar Nov 27 '21 15:11 kffl

It still persist to this date. Latest docker image.

exgame avatar Jan 17 '22 17:01 exgame

Hello, I faced to the same issue too with the version v2.9.14.

gmaurice avatar Jan 20 '22 13:01 gmaurice

Same in v2.9.15

OnkelKeule avatar Jan 29 '22 13:01 OnkelKeule

And Still in v2.9.18

sethiele avatar Apr 19 '22 16:04 sethiele

Also experienced this issue in v2.9.18

I don't understand why this is still not fixed after a year?

kroese avatar Jun 09 '22 06:06 kroese

Well I'm glad its not just me, v2.9.18, same problem!

TopBanana123 avatar Oct 03 '22 21:10 TopBanana123

Same here in v2.9.18. Thought I was loosing my mind!

jonathanhoskin avatar Oct 17 '22 07:10 jonathanhoskin

At least it is not me alone having this issue. Is a fix ever coming out for this? I am on the latest version of Nginx, no issues other than this one known bug

NeitherSound avatar Dec 15 '22 04:12 NeitherSound

Same here in v2.9.19, any help would be appreciated, thanks.

ukewea avatar Dec 29 '22 06:12 ukewea

Hey! Any news on this?

joaquinvacas avatar Mar 19 '23 07:03 joaquinvacas

nope. still have problem, I think It is time to learn something else traefik for example.

Realmagnum avatar Mar 21 '23 18:03 Realmagnum

wow this just happened to me. Debugged for quite a while. I have to manually go through each proxy_host and edit save to let the cert populate in the actual proxy host conf.

iveney avatar Mar 29 '23 03:03 iveney

Can confirm, this is still happening in 2.9.19. Affected all 18 hosts. had to remove each host from the access list and add them all back in.

AustinLeath avatar Jul 04 '23 04:07 AustinLeath

Issue is now considered stale. If you want to keep it open, please comment :+1:

github-actions[bot] avatar Mar 19 '24 01:03 github-actions[bot]