nginx-proxy-manager icon indicating copy to clipboard operation
nginx-proxy-manager copied to clipboard

Update from 2.13.4 to 2.13.5 seems to fail

Open sammyke007 opened this issue 1 month ago • 6 comments

Checklist

  • Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
    • No
  • Are you sure you're not using someone else's docker image?
    • Yes
  • Have you searched for similar issues (both open and closed)?
    • Yes

Describe the bug

If I try to update to v2.13.5 using the proxmox helper script I receive yarn errors. I was asked by the helper scripts mod to report it here.


    _   __      _               ____                           __  ___                                 
   / | / /___ _(_)___  _  __   / __ \_________  _  ____  __   /  |/  /___ _____  ____ _____ ____  _____
  /  |/ / __ `/ / __ \| |/_/  / /_/ / ___/ __ \| |/_/ / / /  / /|_/ / __ `/ __ \/ __ `/ __ `/ _ \/ ___/
 / /|  / /_/ / / / / />  <   / ____/ /  / /_/ />  </ /_/ /  / /  / / /_/ / / / / /_/ / /_/ /  __/ /    
/_/ |_/\__, /_/_/ /_/_/|_|  /_/   /_/   \____/_/|_|\__, /  /_/  /_/\__,_/_/ /_/\__,_/\__, /\___/_/     
      /____/                                      /____/                            /____/             

Hit:1 http://deb.debian.org/debian trixie InRelease
Hit:2 http://security.debian.org trixie-security InRelease                                      
Hit:3 http://openresty.org/package/debian bookworm InRelease                                    
Hit:4 http://deb.debian.org/debian trixie-updates InRelease         
Hit:5 https://deb.nodesource.com/node_22.x nodistro InRelease
24 packages can be upgraded. Run 'apt list --upgradable' to see them.
Warning: http://openresty.org/package/debian/dists/bookworm/InRelease: Policy will reject signature within a year, see --audit for details
Warning: https://deb.nodesource.com/node_22.x/dists/nodistro/InRelease: Policy will reject signature within a year, see --audit for details

changed 13 packages in 2s

28 packages are looking for funding
  run `npm fund` for details
  ✔️   Update Node.js 22
  ⏳   Updating yarn to latest version
changed 1 package in 708ms
  ✔️   Installed Node.js modules: yarn
  ✔️   nginxproxymanager is already up-to-date (v2.13.5)
  ✔️   Stopped Services
  ✔️   Cleaned old files
  ✔️   Set up Environment
yarn install v1.22.22
[1/4] Resolving packages...
success Already up-to-date.
Done in 0.21s.
yarn run v1.22.22
$ tsc && vite build
src/locale/IntlProvider.tsx:5:20 - error TS2307: Cannot find module './lang/it.json' or its corresponding type declarations.

5 import langIt from "./lang/it.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:8:20 - error TS2307: Cannot find module './lang/nl.json' or its corresponding type declarations.

8 import langNl from "./lang/nl.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:12:20 - error TS2307: Cannot find module './lang/vi.json' or its corresponding type declarations.

12 import langVi from "./lang/vi.json";
                      ~~~~~~~~~~~~~~~~


Found 3 errors in the same file, starting at: src/locale/IntlProvider.tsx:5

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[ERROR] in line 128: exit code 0: while executing command $STD yarn build

root@nginxproxymanager:~# 

Nginx Proxy Manager Version

2.13.5

To Reproduce Steps to reproduce the behavior:

  1. Update NPM with bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/nginxproxymanager.sh)"

Expected behavior

Update without errors

Screenshots

Operating System

Proxmox

Additional context

sammyke007 avatar Nov 18 '25 13:11 sammyke007

Maintainer here;

At first, I thought that some “old” files were still present, so Ive added an CLEAN_INSTALL flag for testing purposes (which removes the entire folder before downloading the tarball), then initialized a new tarball. However, the problem persists. It looks like some old routings are still hanging around here? The folders have changed.

MickLesk avatar Nov 18 '25 13:11 MickLesk

Adding yarn locale-compile to frontend/package.json fixes this for me. It looks like after a change in dc89635, TypeScript now resolves all imports at compile time, but those files don't exist on a fresh clone because src/locale/lang/ is gitignored.

hudson-thomas avatar Nov 18 '25 23:11 hudson-thomas

Right

7heMech avatar Nov 19 '25 10:11 7heMech

So right means, the step is needed now at deployment or its an bug in build Pipeline?

MickLesk avatar Nov 19 '25 10:11 MickLesk

I think it's just needed in deployment, but what does your deployment process consist of?

7heMech avatar Nov 20 '25 19:11 7heMech

@jc21 maybe you can tell better.

7heMech avatar Nov 20 '25 19:11 7heMech