Bump certbot-azure-dns version
I need the DNS delegation feature from the azure dns plugin which isn't available in the old version. Therefore I suggest updating the lib to the latest stable version.
Is there a way to get access to the build logs?
I can build the image on my local machine without issues.
If the PR is not valid, is there a way to update the certbot-dns-azure plugin directly in the container?
I tried with pip install --upgrade but it looks like it gets overwritten after trying to add a cert from the UI with the version specified in the certbot-dns-plugins.json.
The build failed CI due to recent major postgres releases. If you want to rebase now, hopefully it should pass.
In case you missed it, the plugins json file has moved here.
Can you confirm this build is working as expected?
Can we also find another person to confirm this build is working?
I just tested it. The build isn't working out of the box. It is necessary to manually set a specific dependency version, since the certbot-azure-dns plugin is not compatible with azure-mgmt-dns in version 9.x.
The workaround I used is described here: https://github.com/terricain/certbot-dns-azure/pull/58#issuecomment-3096456960
There are multiple PRs in the dns plugin repo that would fix that issue: https://github.com/terricain/certbot-dns-azure/pull/58 https://github.com/terricain/certbot-dns-azure/pull/64 https://github.com/terricain/certbot-dns-azure/pull/59
But it seems none of them has been reviewed yet.
I'm not sure if the project is still maintained, the last change was almost a year ago...
Should I mark this PR here as draft until something happens on the related project?
If someone else wants to apply the workaround:
I did it like this:
docker exec -it --rm <nginx-container> /bin/bash to enter the container, then
source /opt/certbot/bin/activate to enable the certbot venv
then
pip install azure-mgmt-dns==8.2.0 to install the needed version.
Docker Image for build 7 is available on DockerHub:
nginxproxymanager/nginx-proxy-manager-dev:pr-4816
[!NOTE] Ensure you backup your NPM instance before testing this image! Especially if there are database changes. This is a different docker image namespace than the official image.
[!WARNING] Changes and additions to DNS Providers require verification by at least 2 members of the community!
I tested the new build and can confirm, that it is now working without manual interaction. From my perspective the PR can be merged.