nginx-proxy-manager icon indicating copy to clipboard operation
nginx-proxy-manager copied to clipboard

websupportsk plugin not working correctly, API update needed?

Open lkxnon opened this issue 1 year ago • 4 comments

What provider would you like to see added to NPM? Websupport.sk

Have you checked if a certbot plugin exists? There is newer version of DNS Authenticator plugin for Certbot https://pypi.org/project/certbot-dns-websupport/ (version certbot-dns-websupport 2.0.1). Seems it is fork from version 0.1.6 used in NPM. I have tested this version 2.0.1 and it works fine from Docker.

This one seems to be faulty and it is quite outaded (2years). There are 404 errors when using this plugin.

websupportsk: {
		display_name:        'Websupport.sk',
		package_name:        'certbot-dns-websupportsk',
		version_requirement: '~=0.1.6',
		dependencies:        '',
		credentials:         `dns_websupportsk_api_key = <api_key>
dns_websupportsk_secret = <secret>
dns_websupportsk_domain = example.com`,
		full_plugin_name: 'dns-websupportsk',

This is error in logs from NPM when trying to use Websupport.sk plugin:

2024-01-10 22:04:19,330:DEBUG:acme.client:Storing nonce: xavOoKHvrBw7alE4Os1fNMF21tAV-IcbMRof84ecu6iECyKuT_8
2024-01-10 22:04:19,332:INFO:certbot._internal.auth_handler:Performing the following challenges:
2024-01-10 22:04:19,332:INFO:certbot._internal.auth_handler:dns-01 challenge for hass.kostrab.sk
2024-01-10 22:04:19,344:DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): rest.websupport.sk:443
2024-01-10 22:04:19,686:DEBUG:urllib3.connectionpool:[https://rest.websupport.sk:443](https://rest.websupport.sk/) "GET /v1/user/self HTTP/1.1" 200 None
2024-01-10 22:04:19,805:DEBUG:urllib3.connectionpool:[https://rest.websupport.sk:443](https://rest.websupport.sk/) "POST /v1/user/self/zone/hass.kostrab.sk/record HTTP/1.1" 404 None
2024-01-10 22:04:19,816:DEBUG:certbot._internal.display.obj:Notifying user: Waiting 120 seconds for DNS changes to propagate

.
.
.
.
.
.
2024-01-10 22:06:24,424:DEBUG:certbot._internal.error_handler:Calling registered functions
2024-01-10 22:06:24,425:INFO:certbot._internal.auth_handler:Cleaning up challenges
2024-01-10 22:06:24,434:DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): rest.websupport.sk:443
2024-01-10 22:06:24,625:DEBUG:urllib3.connectionpool:[https://rest.websupport.sk:443](https://rest.websupport.sk/) "GET /v1/user/self HTTP/1.1" 200 None
2024-01-10 22:06:24,775:DEBUG:urllib3.connectionpool:[https://rest.websupport.sk:443](https://rest.websupport.sk/) "GET /v1/user/self/zone/hass.kostrab.sk/record HTTP/1.1" 404 None
2024-01-10 22:06:24,780:ERROR:certbot._internal.error_handler:Encountered exception during recovery: KeyError: 'items'
2024-01-10 22:06:24,784:DEBUG:certbot._internal.log:Exiting abnormally:
Traceback (most recent call last):

lkxnon avatar Jan 12 '24 10:01 lkxnon

+1

pestig avatar Jan 30 '24 10:01 pestig

I have created a pull request with updated plugins config: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3513

You can use and test this version, it has certbot-dns-websupport version 2.0.1

Unfortunately, for me the challenge fails. I can see the TXT record created in Websupport but I still get "No TXT record found at _acme-challenge.sub.domain.sk",

I have tried to increase Propagation Seconds to 90, but with no success. I'm trying to create wildcard certificate for *.sub.domain.sk which has a A record directed at my server running NPM. Any idea?

EDIT: Nevermind, increasing propagation time to 600 worked

setrin avatar Jan 30 '24 22:01 setrin