nginx-proxy-manager icon indicating copy to clipboard operation
nginx-proxy-manager copied to clipboard

Use latest setuptools

Open dormancygrace opened this issue 2 years ago • 6 comments

I've checked setuptools 64 & 65 - all works as intended (tested on arm64)

dormancygrace avatar Dec 31 '22 03:12 dormancygrace

Why you remove those lines instead of change version only?

binhotvn avatar Jan 26 '23 07:01 binhotvn

Why you remove those lines instead of change version only?

Because there is no need to uninstall latest setuptools and then install version 58

dormancygrace avatar Jan 26 '23 11:01 dormancygrace

The downgrade was initially required because of failing pip installs for certbot plugins. The only way your change can be tested as working is to install every certbot DNS plugin the app supports.

jc21 avatar Mar 07 '23 22:03 jc21

The downgrade was initially required because of failing pip installs for certbot plugins. The only way your change can be tested as working is to install every certbot DNS plugin the app supports.

I've tested reg.ru plugin, duckdns they work fine

dormancygrace avatar Mar 07 '23 22:03 dormancygrace

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-2512

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

PR is now considered stale. If you want to keep it open, please comment :+1:

github-actions[bot] avatar Jan 31 '24 01:01 github-actions[bot]