HSTS Header is added on HTTP hosts - Incorrect implementation of RFC6797
Checklist
- Have you pulled and found the error with
jc21/nginx-proxy-manager:latestdocker image?- Yes / ~~No~~
- Are you sure you're not using someone else's docker image?
- Yes / ~~No~~
- Have you searched for similar issues (both open and closed)?
- Yes / ~~No~~
Describe the bug HSTS is added in the server block of the Nginx for both port 80 and 443 resulting in warnings in various online tooling including hstspreload.org. This probably is caused by the fact that the generated Nginx config combines the port 80 and 443 servers. See: #1 - Redirection host template; #2 - Listen config; #3 - HSTS config
Possible solution Make different server config blocks for port 80 and 443, and only include the HSTS config in the one for 443 if enabled.
Nginx Proxy Manager Version v2.9.18
Any plans to fix this?
Issue is now considered stale. If you want to keep it open, please comment :+1:
As far as I know, this issue still persists