nginx-proxy-manager icon indicating copy to clipboard operation
nginx-proxy-manager copied to clipboard

Internal Error instead of: Your DNS is wrong

Open kubo6472 opened this issue 3 years ago • 3 comments

Describe the bug When my dns is setup wrong, it says just internal error, instead of something proper

Nginx Proxy Manager Version v2.9.18

To Reproduce Steps to reproduce the behavior:

  1. Create an SSL cert for a domain with wrong dns
  2. See error

Expected behavior A proper error.

kubo6472 avatar Aug 31 '22 20:08 kubo6472

What do you mean by "dns is setup wrong"? Here just a few things that this could mean:

  1. DNS server setup on the container is broken
  2. DNS for the requested SSL cert doesn't point to an IP forwarded to NPM.
  3. DNS based SSL challenge config not correct

the1ts avatar Sep 01 '22 20:09 the1ts

A/cname for that subdomain was pointing elsewhere

kubo6472 avatar Sep 02 '22 12:09 kubo6472

When you go to the SSL section there is already a button to test server reachability, its not done by default since not everyone would want site24x7.com knowing or contacting their site. That surely would have found the error, for example if I do it for a hostname not being handled by NPM it gives the feedback its a valid hostname in the domain but not hosted by NPM. Testing further inside NPM would be complex for all the edge cases such as

  1. Split horizon DNS
  2. Different IPs on outbound and inbound to/from NPM. i.e. outbound via gateway, inbound via load balancer.
  3. NAT hairpinning not traversing onto the internet IP space

the1ts avatar Sep 02 '22 12:09 the1ts

Issue is now considered stale. If you want to keep it open, please comment :+1:

github-actions[bot] avatar Feb 11 '24 01:02 github-actions[bot]

It's still an issue

kubo6472 avatar Feb 11 '24 11:02 kubo6472