ShadowedUnitFrames icon indicating copy to clipboard operation
ShadowedUnitFrames copied to clipboard

Fix: Editmode unable to save issue

Open dingoh opened this issue 1 year ago • 4 comments

Don't hook :hideFrame when going into EditMode.

(I am the same person who posted this- https://www.wowace.com/projects/shadowed-unit-frames/issues/2102)

dingoh avatar Aug 05 '24 03:08 dingoh

I'm not able to observe any issues with EditMode snapping or saving in current WoW with current SUF. Can you explain how to reproduce the issue?

Nevcairiel avatar Aug 16 '24 08:08 Nevcairiel

I'm not able to observe any issues with EditMode snapping or saving in current WoW with current SUF. Can you explain how to reproduce the issue?

The issue occurs when I check any 'Hide Blizz frame' and enter to Edit mode.

Detail of my settings: Unit Enable : Player, Target, Target of target, Focus, Target of focus, Boss Blizz Disable : Target, Boss, Focus

Details of the issue: When you move any frame in Editmode, the error occurs(regarding SUF), and then you can not save current editing setttings at all.

*This issue has been quite long time for me and some of my friends like since DF Season 3

dingoh avatar Aug 16 '24 16:08 dingoh

Confirm the same for me partially hidden the bliz frames use some parts then it breaks for me without this change.

nulian avatar Aug 16 '24 18:08 nulian

@Nevcairiel

Please watch this https://www.youtube.com/watch?v=UpHkO9CobMU

I had forgotten to mention the keystone of the error earlier. That was 'Snap to Elements' option in the Edit mode. You can find that in this video.

dingoh avatar Aug 17 '24 07:08 dingoh

Any update on this? I can reproduce it even with a new profile and SUF being the only addon enabled.

To add a bit of extra info, here's the lua error I get when I try to move anything in Edit Mode with SUF enabled + "Snap to Elements":

Message: ...izzard_EditMode/Mainline/EditModeSystemTemplates.lua:560: attempt to perform arithmetic on local 'left' (a nil value)
Time: Mon Mar 31 14:58:04 2025
Count: 235
Stack:
[Interface/AddOns/Blizzard_EditMode/Mainline/EditModeSystemTemplates.lua]:560: in function 'GetScaledSelectionSides'
[Interface/AddOns/Blizzard_EditMode/Mainline/EditModeSystemTemplates.lua]:532: in function 'IsVerticallyAlignedWithFrame'
[Interface/AddOns/Blizzard_EditMode/Mainline/EditModeSystemTemplates.lua]:755: in function 'GetFrameMagneticEligibility'
[Interface/AddOns/Blizzard_EditMode/Mainline/EditModeUtil.lua]:152: in function 'GetEligibleMagneticFrames'
[Interface/AddOns/Blizzard_EditMode/Mainline/EditModeUtil.lua]:341: in function 'GetMagneticFrameInfoOptions'
[Interface/AddOns/Blizzard_EditMode/Mainline/EditModeUtil.lua]:424: in function 'GetMagneticFrameInfos'
[Interface/AddOns/Blizzard_EditMode/Mainline/EditModeManager.lua]:967: in function 'RefreshSnapPreviewLines'
[Interface/AddOns/Blizzard_EditMode/Mainline/EditModeManager.lua]:72: in function <...ddOns/Blizzard_EditMode/Mainline/EditModeManager.lua:70>

Locals:
self = BossTargetFrameContainer {
 systemInfo = <table> {
 }
 downKeys = <table> {
 }
 smallSize = true
 spacing = 10
 alwaysUseTopRightAnchor = true
 isManagedFrame = true
 hasActiveChanges = false
 dirty = false
 isHighlighted = true
 systemIndex = 6
 isInEditMode = true
 snappedFrames = <table> {
 }
 isRightManagedFrame = true
 layoutParent = UIParentRightManagedFrameContainer {
 }
 savedSystemInfo = <table> {
 }
 systemNameString = "Boss Frames"
 isSelected = false
 castBarOnSide = true
 dirtySettings = <table> {
 }
 settingMap = <table> {
 }
 settingDisplayInfoMap = <table> {
 }
 settingsDialogAnchor = <table> {
 }
 BossTargetFrames = <table> {
 }
 hideWhenActionBarIsOverriden = false
 Selection = Frame {
 }
 respectChildScale = true
 layoutIndex = 4
 align = "right"
 breakSnappedFramesOnSave = true
 defaultHideSelection = true
 system = 3
 rightPadding = -70
}
left = nil
bottom = nil
width = nil
height = nil
scale = 1
(*temporary) = BossTargetFrameContainer {
 systemInfo = <table> {
 }
 downKeys = <table> {
 }
 smallSize = true
 spacing = 10
 alwaysUseTopRightAnchor = true
 isManagedFrame = true
 hasActiveChanges = false
 dirty = false
 isHighlighted = true
 systemIndex = 6
 isInEditMode = true
 snappedFrames = <table> {
 }
 isRightManagedFrame = true
 layoutParent = UIParentRightManagedFrameContainer {
 }
 savedSystemInfo = <table> {
 }
 systemNameString = "Boss Frames"
 isSelected = false
 castBarOnSide = true
 dirtySettings = <table> {
 }
 settingMap = <table> {
 }
 settingDisplayInfoMap = <table> {
 }
 settingsDialogAnchor = <table> {
 }
 BossTargetFrames = <table> {
 }
 hideWhenActionBarIsOverriden = false
 Selection = Frame {
 }
 respectChildScale = true
 layoutIndex = 4
 align = "right"
 breakSnappedFramesOnSave = true
 defaultHideSelection = true
 system = 3
 rightPadding = -70
}
(*temporary) = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on local 'left' (a nil value)"

Ulimn avatar Mar 31 '25 13:03 Ulimn