Nevcairiel
Enable "Hide in >5-man raids" option on Raid Frames
I split the hideSemiRaid option into hideSemiRaidRaid and hideSemiRaidParty as denoted in the options. Naming is a bit weird on it, open to changes to that.
Purpose is to enable Party frames to use the Raid Frames code so we can get role based filtering which seems to be an incredibly highly requested change over the last uh... checks notes 10 years?
I did notice a bug was occurring with CheckGroupVisibility in the party block making it so unless both raid and party frames were enabled, the raid frames with show party as raid enabled will not be visible. Unsure if thats intended or not.
You say the purpose is to be able to use raid frames in parties, but thats already possible, in fact the new option doesn't do anything to that effect. "Show party as raid" does that.
Please elaborate on the actual use-case.
You say the purpose is to be able to use raid frames in parties, but thats already possible, in fact the new option doesn't do anything to that effect. "Show party as raid" does that.
Please elaborate on the actual use-case.
Use Case: I want to use Grid2 as my raid frames, not SUF. Normally this would be fine, I would enable party frames only.
However, I'd like to sort by role ie Tank -> Healer -> 3 DPS Thus, I'd also like to use the "Show party as raid" setting where thats possible. This requires me to enable raid frames though.
I don't really actually want the raid frames, I only want party frames that allow me to sort by role. Normally this would be fine, it works like intended until I join an actual raid and the frames don't go away because theres no option to disable the frames when in a raid of more than 5 people.
This PR addresses that.
Just figured I'd push the changes up-stream that I made, I have no misgivings that this code is of any quality. The naming of everything sucks and it isn't self-documenting but I did notice that a lot of people requested "sort by role in party frames" as a feature and a quick solution a decade later is better than none at all IMO.