LAVFilters icon indicating copy to clipboard operation
LAVFilters copied to clipboard
verified publisher icon Nevcairiel

Crash in dxva2_h264_end_frame

Open clsid2 opened this issue 6 months ago • 1 comments

What happens is that ff_dxva2_common_end_frame returns an error code. Then it calls ff_h264_draw_horiz_band which results in a memcpy fail.

Interestingly, there was a patch on the FFmpeg mailing list to remove the function: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-June/329261.html But it was never committed.

This crash has happened over 10.000 times in past years. Example dump.

Since there already is a failure situation, is there any point in calling ff_h264_draw_horiz_band?

clsid2 avatar Jul 08 '25 17:07 clsid2

I agree with this - the h264 decoder does not have the AV_CODEC_CAP_DRAW_HORIZ_BAND flag, in theory you can safely remove the ff_h264_draw_horiz_band function.

Aleksoid1978 avatar Jul 15 '25 04:07 Aleksoid1978