heyoo icon indicating copy to clipboard operation
heyoo copied to clipboard

requests_toolbelt is not listed as a dependency

Open soerenetler opened this issue 1 year ago • 1 comments

Hi, requests_toolbelt is used by not probably defined as a dependency in the setup.py. It is just used in one place. I think it would be a better approach to remove it to not add too many dependencies. I don't think it is even necessary there.

I would happily create a PR if it is decided which approach (add a dependency or change code) to go with.

soerenetler avatar Oct 05 '22 12:10 soerenetler

Hi @soerenetler

This makes sense, if you have a better approach to reproduce what requests_toolbelt does without any extra dependencies please proceed and Create a PR for it.

Kalebu avatar Oct 06 '22 12:10 Kalebu

This is solved with #36

soerenetler avatar Oct 23 '22 18:10 soerenetler