Add 'target_tables' kwarg to DynamicTable subclasses
Motivation
Fix #2096
How to test the behavior?
Create extension that defines a DynamicTableRegion column. Use get_class to get the class, and use the target_tables keyword argument. See https://github.com/rly/ndx-optogenetics/pull/6
Checklist
- [ ] Did you update CHANGELOG.md with your changes?
- [x] Have you checked our Contributing document?
- [x] Have you ensured the PR clearly describes the problem and the solution?
- [x] Is your contribution compliant with our coding style? This can be checked running
ruff check . && codespellfrom the source directory. - [x] Have you checked to ensure that there aren't other open Pull Requests for the same change?
- [x] Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 95.19%. Comparing base (b0973cc) to head (27244f1).
:warning: Report is 1 commits behind head on dev.
Additional details and impacted files
@@ Coverage Diff @@
## dev #2097 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 28 28
Lines 2851 2851
Branches 736 736
=======================================
Hits 2714 2714
Misses 83 83
Partials 54 54
| Flag | Coverage Δ | |
|---|---|---|
| integration | 74.04% <100.00%> (ø) |
|
| unit | 85.16% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@rly added a test and the target_tables arg to a few tables that I think were added since this PR had been created if you want to review
Thank you @stephprince . This looks great to me. Please approve.