pynwb icon indicating copy to clipboard operation
pynwb copied to clipboard

[Feature]: DecompositionSeries BandsTable should be typed

Open mavaylon1 opened this issue 10 months ago • 1 comments

What would you like to see added to PyNWB?

From making columns in DynamicTable expandable by default, the edge case of "named but untyped" types blocks full support of that feature. The current known types are ElectrodesTable and the bands table in DecompositionSeries. The reason this is an issue is that the shape definition is not being used from the untyped type but from the schema of DynamicTable.

Bands Table: The schema defines the shape to be [None, 2]. We want the shape so that we don't override schema set values when making things expandable. In this case, We want the shape of the dataset to be written as [None, 2] and not [None, None], i.e., not expandable in dimensions that are defined not to be.

The fix is to create a type for Bands Table.

Is your feature request related to a problem?

Above

What solution would you like?

Above.

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

mavaylon1 avatar Feb 27 '25 19:02 mavaylon1

https://github.com/hdmf-dev/hdmf/pull/1180

mavaylon1 avatar Feb 27 '25 19:02 mavaylon1

This was addressed by #2063 which is now merged.

stephprince avatar Jun 27 '25 16:06 stephprince