pynwb icon indicating copy to clipboard operation
pynwb copied to clipboard

Deprecate EventWaveform class

Open rly opened this issue 1 year ago • 1 comments

Motivation

Corresponds to https://github.com/NeurodataWithoutBorders/nwb-schema/pull/584

  • Waiting on test suite to pass
  • Waiting on schema changes to merge to dev

How to test the behavior?

EventWaveform()  # should return a ValueError

Checklist

  • [ ] Did you update CHANGELOG.md with your changes?
  • [x] Have you checked our Contributing document?
  • [x] Have you ensured the PR clearly describes the problem and the solution?
  • [x] Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • [x] Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • [x] Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

rly avatar Jul 23 '24 21:07 rly

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (nwb_schema_2.8.0@f89ce99). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/pynwb/ecephys.py 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@                 Coverage Diff                 @@
##             nwb_schema_2.8.0    #1940   +/-   ##
===================================================
  Coverage                    ?   92.02%           
===================================================
  Files                       ?       27           
  Lines                       ?     2709           
  Branches                    ?      706           
===================================================
  Hits                        ?     2493           
  Misses                      ?      141           
  Partials                    ?       75           
Flag Coverage Δ
integration 72.90% <33.33%> (?)
unit 82.98% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 23 '24 21:07 codecov[bot]

I accidentally updated the changelog in the nwb_schema_2.8.0 branch. I think we can move forward with this commit to that branch.

rly avatar Nov 19 '24 17:11 rly