pynwb icon indicating copy to clipboard operation
pynwb copied to clipboard

Update to ruff, update workflow versions

Open mavaylon1 opened this issue 1 year ago • 2 comments

Motivation

What was the reasoning behind this change? Please explain the changes briefly. TODO

  • [ ] Finish updating tox.ini to support 3.12
  • [ ] Update coverage and codespell
  • [ ] Migrate to use hatch and hatch-vcs
  • [ ] Fix ros3 failure
  • [ ] Update gallery tests to drop imp module for importlib.utils due to python 3.12
  • [ ] Add ruff and drop flake8

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • [ ] Did you update CHANGELOG.md with your changes?
  • [ ] Have you checked our Contributing document?
  • [ ] Have you ensured the PR clearly describes the problem and the solution?
  • [ ] Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • [ ] Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • [ ] Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

mavaylon1 avatar Feb 22 '24 15:02 mavaylon1

AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'? It seems pkgutil deprecated this method on python 3.12 (https://stackoverflow.com/questions/77364550/attributeerror-module-pkgutil-has-no-attribute-impimporter-did-you-mean)

This does not happen in hdmf or hdmf-zarr (why here?)

mavaylon1 avatar Mar 07 '24 16:03 mavaylon1

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 91.96%. Comparing base (8b42af3) to head (ad5ed23).

Files Patch % Lines
src/pynwb/icephys.py 0.00% 3 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1853   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files          27       27           
  Lines        2663     2663           
  Branches      700      686   -14     
=======================================
  Hits         2449     2449           
  Misses        142      142           
  Partials       72       72           
Flag Coverage Δ
integration 72.36% <40.00%> (ø)
unit 84.07% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 11 '24 20:03 codecov[bot]

@rly could you take a look at the codecov patch? I think we can ignore the issue in patch since the project coverage is passing. The patch itself is pointing to import changes I made for getting the version and also style changes in icephys.py that were already untested.

mavaylon1 avatar Mar 12 '24 19:03 mavaylon1

I'm going to give this a pass through today prior to review requesting. @rly

mavaylon1 avatar Mar 12 '24 19:03 mavaylon1

I think we can ignore the issue in patch since the project coverage is passing. The patch itself is pointing to import changes I made for getting the version and also style changes in icephys.py that were already untested.

I agree. That's all fine.

rly avatar Mar 12 '24 21:03 rly

Looks great. Thank you for taking care of this much needed infrastructure update @mavaylon1

rly avatar Mar 23 '24 05:03 rly