nwbwidgets
nwbwidgets copied to clipboard
[Bug]: `make_trial_event_controller` criteria for time columns allows `"_time"` to appear anywhere in column name
What happened?
The logic in make_trial_event_controller
to determine trial event columns checks for "_time" in column_name
, which is weaker than column_name.endswith("_time")
, the check used by nwbinspector
for example. Unsure what the consensus standard is here but in my case a boolean column called "has_timeout"
was included as an alignment field, so I think the stronger check would be better.
Steps to Reproduce
n/a
Traceback
n/a
Operating System
Linux
Python Version
3.10
Package Versions
nwbinspector==0.11.3
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
- [X] Have you ensured this bug was not already reported?