nwbwidgets icon indicating copy to clipboard operation
nwbwidgets copied to clipboard

Update icephys accordions with AlignedDynamicTable and renamings

Open lvsltz opened this issue 5 years ago • 4 comments

There have been some major changes since February in ndx-icephys-meta and this PR syncs nwb-jupyter-widges with that extension:

  • some tables have been renamed
  • IntracellularRecordingsTable is now an AlignedDynamicTable

lvsltz avatar Jun 08 '20 09:06 lvsltz

@lvsltz thanks, these changes look great!

Do you know if these changes were associated with version numbers? I'm worried that after we make these changes someone might install an older version of ndx-icephys-meta and then have the opposite problem. The best way to avoid this is to explicitly enforce specific versions in the requirements or setup.py files. I'll take a look at the ndx-icephys-meta repo to see if we can refer to specific release versions.

bendichter avatar Jun 08 '20 12:06 bendichter

It looks like the last (and only) release was Feb 3, and many of these changes were made March 3-4, so they are unreleased. In general, I only want to depend on released code (on pypi), so I'm going to wait to merge this until those changes are in an official pypi release. Also, I'm going to add a version constraint for when this is eventually merged.

bendichter avatar Jun 08 '20 12:06 bendichter

Indeed, it makes sense to wait. I overlooked the pypi release.

lvsltz avatar Jun 08 '20 15:06 lvsltz

This is very helpful nevertheless! Thanks for helping me keep on top of this!

bendichter avatar Jun 08 '20 16:06 bendichter