nwb-schema icon indicating copy to clipboard operation
nwb-schema copied to clipboard
verified publisher icon NeurodataWithoutBorders

OptogeneticStimulusSite description

Open bendichter opened this issue 6 years ago • 1 comments

OptogeneticStimulusSite.description is a dataset. This isn't inherently a problem, but it is inconsistent with TimeSeries.description, which is an attribute.

https://github.com/NeurodataWithoutBorders/nwb-schema/blob/99fbbdc68984ccb7c2fdb30e921f55f152e5b4a2/core/nwb.ogen.yaml#L24-L31

Maybe not worth fixing for 2.x if it will cause compatibility issues, but worth correcting in 3.0

bendichter avatar Dec 23 '19 21:12 bendichter

I agree, since this is just a minor inconsistency between the types, we should probably wait with this for 3.0. Thanks for creating the issue. It is helpful to keep track of these issues as we find them.

oruebel avatar Dec 23 '19 22:12 oruebel