nwb-schema icon indicating copy to clipboard operation
nwb-schema copied to clipboard

[WIP] add UnitSeries neurodata_type

Open ajtritt opened this issue 6 years ago • 3 comments

This is a proposal/work-in-progress for addressing #194. It adds a new type, called UnitSeries, that would replace Clustering. It extends TimeSeries and requires that TimeSeries.data be an int. It also adds an additional dataset, called units that is a DynamicTableRegion that points to Units table.

ajtritt avatar Jan 17 '19 01:01 ajtritt

Would this allow two or more spikes from different units with the same timestamp? (This can happen in real data)

tjd2002 avatar Jan 17 '19 02:01 tjd2002

@tjd2002

Would this allow two or more spikes from different units with the same timestamp? (This can happen in real data)

Yes, there are no restrictions on unique time stamps in TimeSeries

ajtritt avatar Jan 17 '19 15:01 ajtritt

I'm fine with the name change, and I like that this now inherits from TimeSeries, but it would be nice if there was some kind of link to SpikeEventSeries (https://github.com/NeurodataWithoutBorders/nwb-schema/issues/239). As it stands now, if you had multiple UnitSeries and multiple SpikeEventSeries objects (e.g., 6, one for each of 6 shanks), it is unclear how you would indicate which SpikeEventSeries object is connected to which UnitSeries object. I guess you could do it implicitly if both had a field for referencing the regions of the Units table, and you implied that objects that referenced the same Units table region were connected.

bendichter avatar Jan 17 '19 18:01 bendichter