nwb-guide icon indicating copy to clipboard operation
nwb-guide copied to clipboard

Correctly handle converter electrodes

Open garrettmflynn opened this issue 1 year ago • 1 comments

This PR fixes the issue where the SpikeGLXRecordingInterface and SpikeGLXConverter have inconsistent behaviors and the latter cannot be converted.

The solution was to iterate over the interfaces of a sub-converter instead of checking it directly for relevant metadata.

garrettmflynn avatar May 02 '24 22:05 garrettmflynn

Looks good - probably waiting on the big e2e PR for tests?

CodyCBakerPhD avatar May 03 '24 19:05 CodyCBakerPhD

That would be a great test case. Can add to the YAML here

garrettmflynn avatar May 13 '24 20:05 garrettmflynn

Any idea why these results might be returned though?

Screenshot 2024-05-13 at 1 37 21 PM

garrettmflynn avatar May 13 '24 20:05 garrettmflynn

@garrettmflynn Yes, that makes perfect sense because NIDQ electrodes aren't on a shank - and I'm fairly sure from digging into that sub interface that its individual metadata schema should not require it

Should be able to test that out on an individual NIDQ-only pipeline

The real problem is how NWB makes one common table for all electrodes, but the new ecephys extension will hopefully resolve that (and hopefully be integrated to core to resolve) - regardless, NeuroConv can currently resolve that issue for us

This would be a good thing for us to pair program a debug and potential refactor in a longer (~2 hour?) meeting tomorrow

CodyCBakerPhD avatar May 14 '24 17:05 CodyCBakerPhD

Awesome. Looking forward to it

garrettmflynn avatar May 14 '24 17:05 garrettmflynn

Fixed in tandem with https://github.com/catalystneuro/neuroconv/pull/860

garrettmflynn avatar May 15 '24 18:05 garrettmflynn