matnwb icon indicating copy to clipboard operation
matnwb copied to clipboard

Add example for creating pixel mask to ophys tutorial (inspired by #572)

Open ehennestad opened this issue 1 year ago • 3 comments

Motivation

It was unclear how to create pixel_mask for PlaneSegmentation objects. This was raised in issue #572

How to test the behavior?

open ophys.mlx

Checklist

  • [x] Have you ensured the PR description clearly describes the problem and solutions?
  • [x] Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • [ ] If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

ehennestad avatar Jul 01 '24 18:07 ehennestad

@bendichter @lawrence-mbf one test fails, related to nwb version. Is that due to matnwb still being on v2.6.0?

ehennestad avatar Jul 08 '24 21:07 ehennestad

@bendichter @lawrence-mbf one test fails, related to nwb version. Is that due to matnwb still being on v2.6.0?

Yeah, the message implies that pynwb is using 2.7.0 by default.

lawrence-mbf avatar Jul 08 '24 21:07 lawrence-mbf

@ehennestad this looks great! Just one minor edit, then it's good to go

bendichter avatar Jul 27 '24 02:07 bendichter

@bendichter

ehennestad avatar Aug 26 '24 16:08 ehennestad