moabb Is this code redundant?

https://github.com/NeuroTechX/moabb/blob/bea3ec0a44ef419cb9537f0eeeafd94d73d39478/moabb/evaluations/evaluations.py#L196

moabb/evaluations/evaluations.py

The lines 187-196 don't return any and the parameters don't match those below—are these redundant code?

Feb 18 '25 10:02 allwaysFindFood

Hey @allwaysFindFood,

maybe, but we want to remove this type of evaluation and depend only on splitters. This whole part of the evaluation will be refactored for better future maintainability, if you have any feedback or wishes, please let me know

Feb 21 '25 09:02 bruAristimunha

@bruAristimunha may be we can welcome a PR to fix the existing evaluation. I suspect it will still live for some time, before being removed. What do you think?

Feb 21 '25 10:02 gcattan

I really hope not too long, we are working on the Moabb meeting every two weeks to try to prioritize what is blocked.

Regarding the reported line, basically in the folder creation function we have two behaviors that are controlled by the same flag. It seems redundant, but it wasn't at the time it was proposed.

Definitely needs some refinement, but we already we will do this soon.

Feb 21 '25 10:02 bruAristimunha