python-neo icon indicating copy to clipboard operation
python-neo copied to clipboard

Add filename property

Open PeterNSteinmetz opened this issue 1 year ago • 1 comments

Adds the OriginalFileName property to the NlxHeader. Also cleans up private members and moves a useful method to NlxHeader from test.

This is the last in this sequence of commits for a while now. This now provides a much clearer method of parsing the header which works with all extant files (@JuliaSprenger and thus provides that refactoring discussed a while back ;-). It should be more flexible for future possible variations and easier to modify if needed.

If one wanted to squish all of these since the divergence to master there would be much cleaner code to review, however, it would be major changes in one shot.

PeterNSteinmetz avatar Sep 26 '24 21:09 PeterNSteinmetz

Thanks Peter. Sam said he would review this when he has some time. So I assigned him to all of these and he will be the main reviewer.

zm711 avatar Sep 27 '24 12:09 zm711

Hi Peter, I read the long series of PR that depend of the previous ones. I am OK with all changes.

Because of conflict I propose to merge only this last one that should include all of then. In short merging this one should include also: #1562 #1563 #1566 #1567 #1568

I will push the fix myself.

samuelgarcia avatar Jul 02 '25 10:07 samuelgarcia

@zm711 : this is ready to merge on my side.

samuelgarcia avatar Jul 02 '25 12:07 samuelgarcia