python-neo icon indicating copy to clipboard operation
python-neo copied to clipboard

[No Merge] Added command to unlock annex repo to restore files from symbolic links.

Open nikhilchandra opened this issue 1 year ago • 8 comments

fixes #1550

I did a little digging and I think the problems with downloaded files being replaced with 1KB symbolic links has to do with the way annex repositories work. I added an "unlock" command after the forced checkout and it seems to fix the issue on my Windows computer.

nikhilchandra avatar Sep 18 '24 16:09 nikhilchandra

It looks to me like this doesn't break the linux based CI. I'll leave this open for a little bit to see if anyone else has feelings about this, but I'm okay with it.

Also @nikhilchandra you don't show up as having ever contributed code. Is that intentional (ie you did a github setting) is it a github bug?

zm711 avatar Sep 18 '24 16:09 zm711

@zm711 If you don't mind, I would prefer to not merge this pull request. It worked yesterday on my machine for test_plexon2rawio.py but I just ran pytest again from the root directory and there are a lot of breaks. I would like to hold off until there is a better understanding of what's going on. Is it possible to just mark the PR as put on hold for later consideration?

I have not been very active on github until recently. I used Bitbucket in grad school and since my projects were solo everything was in private repos.

nikhilchandra avatar Sep 18 '24 18:09 nikhilchandra

Yeah, I'll mark as request changes which lets the team know not to merge.

I was mainly asking to make sure you got credit for your contributions unless you had some setting for privacy. This seems like a github bug in that it is is saying that you haven't contributed anything to the repo. Seems weird, but who knows.

zm711 avatar Sep 18 '24 18:09 zm711

@zm711 Is there a more private mechanism for communicating over github?

nikhilchandra avatar Sep 18 '24 18:09 nikhilchandra

Not that I know of. You can use my throw away email if needed mineurs-torrent0x [at] icloud.com

zm711 avatar Sep 18 '24 18:09 zm711

@JuliaSprenger could you comment on this please?

zm711 avatar Oct 11 '24 13:10 zm711

Hey @nikhilchandra we've discussed this a bit more and we agree with the git-annex and datalad documentation that basically we don't know if this will ever really work with Windows so the preferred for this testing is to use Mac/Linux. You could try to mimic what @h-mayorquin has done in the spikeinterface ci to get windows to work for some stuff. We can wait to see if @JuliaSprenger has any opinions on this, but we will likely close this if she doesn't feel strongly about this.

zm711 avatar Oct 12 '24 16:10 zm711

Gotcha. It was worth a try :)

nikhilchandra avatar Oct 15 '24 04:10 nikhilchandra