python-neo icon indicating copy to clipboard operation
python-neo copied to clipboard
verified publisher icon NeuralEnsemble

Fix for #1530 [IgorIO and missing "xUnits"]

Open apdavison opened this issue 1 year ago • 2 comments

"xUnits" is only used in Versions 1, 2, 3 of .pxp files; Version 5 uses "dimUnits" - see https://github.com/AFM-analysis/igor2/blob/43fccf51714661fb96372e8119c59e17ce01f683/igor2/binarywave.py#L501

apdavison avatar Aug 27 '24 13:08 apdavison

The files I have are around 70 MB, which is probably too big for a test file, no?

apdavison avatar Aug 27 '24 13:08 apdavison

Yeah, the goal is < 10 MB. We are currently checking with @JuliaSprenger if a couple 20MB files are okay. Okay, I mean it would be better to have test files.

Could we maybe add a comment by the if-elif-else block saying that this header info is confirmed by you and that if other file formats appear that we will address those later; currently need testing files. Or something of that nature?

zm711 avatar Aug 27 '24 13:08 zm711